New Patch

Apr 3, 2010 at 10:36 AM

Andrew,

Not sure if you have seen the patch that I uploaded. See - http://timeline.codeplex.com/SourceControl/PatchList.aspx

Adrian.

Apr 5, 2010 at 6:05 PM

I've added you as a dev to the project, you can apply your patch, just make sure it works with silverlight/javascript/wpf project samples. Thanks, Andrew

Apr 5, 2010 at 6:17 PM

one thing. please follow code formatting guidelines (it's just matter of consistency). For instance

 

public string Id
{
      get { return m_timelineEvent.Id; }
      set { m_timelineEvent.Id = value; }
}

// should be:

public string Id
{
   get
   {    
         return m_timelineEvent.Id;
   }

set { m_timelineEvent.Id = value; } }

 

Apr 5, 2010 at 11:14 PM

No dramas... I will just have to turn a number of resharper settings off, and get my head into a little bit more of the style of C++ :).

 

I will probably write some unit test around the areas that I change.  I did not spot any in the code base ? Is this right ? Or am I missing something ?

 

 

Apr 6, 2010 at 5:42 PM

No unit tests, so far :)